Patchinfo tests #3160
Merged
Patchinfo tests #3160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generation of the package link was failing calling patchinfo_bread_crumb
in the helper spec. Thus I changed this in the helper.
====
ActionController::UrlGenerationError: No route matches {:action=>"show", :package=>"package_1", :project=>"project_1"}
Codecov Report
@@ Coverage Diff @@
## master #3160 +/- ##
==========================================
+ Coverage 88.93% 88.93% +<.01%
==========================================
Files 263 263
Lines 17591 17587 -4
==========================================
- Hits 15644 15641 -3
+ Misses 1947 1946 -1
|
DavidKang
suggested changes
May 30, 2017
| @@ -41,7 +41,10 @@ | |||
| - if @issues.present? | |||
| %ul | |||
| - @issues.each do |issue| | |||
| = issue_link(issue) | |||
| - if issue[0] == "CVE" | |||
| = content_tag(:li, link_to((issue[1]).to_s, issue[2]) + ": #{issue[3]}") | |||
There was a problem hiding this comment.
Why content_tag?, and not something like %li= link_to((issue[1]).to_s, issue[2]) + ": #{issue[3]}"
There was a problem hiding this comment.
Good point. Didn't think of that
| - if issue[0] == "CVE" | ||
| = content_tag(:li, link_to((issue[1]).to_s, issue[2]) + ": #{issue[3]}") | ||
| - else | ||
| = content_tag(:li, link_to("#{issue[0]}##{issue[1]}", issue[2]) + ": #{issue[3]}") |
|
Nice work! |
The code is only used once and not very complex. No need to have it in a helper.
|
@DavidKang Changed it now |
DavidKang
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.